Skip to content

Comments

Fix eventArgs not being merged correctly for BelongsOrMorphToMany relations#122

Merged
LukeTowers merged 1 commit intowintercms:developfrom
ericp-mrel:fix/morph-to-many-relations
Oct 5, 2022
Merged

Fix eventArgs not being merged correctly for BelongsOrMorphToMany relations#122
LukeTowers merged 1 commit intowintercms:developfrom
ericp-mrel:fix/morph-to-many-relations

Conversation

@ericp-mrel
Copy link
Contributor

This PR fixes an issue introduced when PR #120 was merged and fixes the issue where the eventArgs are not being properly merged.

This comment also explains the issue using the + operator with non-associative arrays: #120 (comment)

…ator.

This fixes the issue with the arrays not being merged properly with auto-incremented keys.
@LukeTowers LukeTowers marked this pull request as ready for review October 5, 2022 16:15
@LukeTowers LukeTowers added this to the 1.2.1 milestone Oct 5, 2022
@LukeTowers LukeTowers merged commit 57c7669 into wintercms:develop Oct 5, 2022
@ericp-mrel ericp-mrel deleted the fix/morph-to-many-relations branch October 10, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants