Skip to content

Comments

Patch alert method to keep compatibility with Laravel#125

Merged
LukeTowers merged 2 commits intodevelopfrom
jaxwilko-patch-1
Oct 18, 2022
Merged

Patch alert method to keep compatibility with Laravel#125
LukeTowers merged 2 commits intodevelopfrom
jaxwilko-patch-1

Conversation

@jaxwilko
Copy link
Member

Laravel just released v9.36 which includes this PR: laravel/framework#44614

The PR adds a verbosity param to the command alert() method, this causes us the issue:

Fatal error: Declaration of Winter\Storm\Console\Command::alert($string) must be compatible with Illuminate\Console\Command::alert($string, $verbosity = null)

This PR adds the param to ensure we are compatible with the upstream

@LukeTowers LukeTowers merged commit 6d2d552 into develop Oct 18, 2022
@mjauvin mjauvin added this to the 1.2.1 milestone Oct 19, 2022
@LukeTowers LukeTowers deleted the jaxwilko-patch-1 branch October 20, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants