Add event to make model validation extendable

[mjauvin]

Needed to add Validation to translatable Model attributes in Winter.Translate plugin.

Used by wintercms/wn-translate-plugin#52

[what-the-diff]

• Added a new event 'model.getValidationAttributes'
• The model will fire this event when fetching the attributes to validate the model
• If any listeners return an array, it will be used as validation attributes instead of $this->attributes (the default)

[mjauvin]

@bennothommo any idea what the error in code analysis is about?

[bennothommo]

The static code analysis test has been a bit flaky recently. Feel free to ignore it for now.

[bennothommo]

@mjauvin is it possible to just dynamically extend a model and add validation rules?

Model::extend(function ($model) {
    $model->rules['newField'] = 'required';
    // etc...
});

[mjauvin]

@bennothommo not sure I understand the relevance here

[bennothommo]

@mjauvin I'm asking if there's any need to create a new event when a model extension can do it already.

If the Translatable behavior needs to implement validation on the fly, you can create a Rule class which handles the validation needed for the translation, and simply add that Rule class through the model extension.

[mjauvin]

@bennothommo but it doesn't need to create new rules. just apply the existing rules to the translations.

[mjauvin]

Any objection on merging this?

[LukeTowers]

@bennothommo any thoughts on this?

[bennothommo]

Nope, no additional thoughts. If it works, it's all good by me.

[github-actions]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[mjauvin]

Can this be merged, it would allow me to continue work on the associated PR in Translate plugin (wintercms/wn-translate-plugin#52) ?