Remove deprecated "get_parent_class" calls in Extendable trait.#153
Remove deprecated "get_parent_class" calls in Extendable trait.#153LukeTowers merged 3 commits intodevelopfrom
Conversation
This uses Reflection to instead determine the parent class and available magic methods to pass through to. In order to prevent infinite looping (which could've potentially been a problem before), it will also ignore any "extendable" classes when determining the parent. Also fixed some tests that were using undefined class properties, and were also throwing deprecation errors. Replaces #152
|
Can't we use |
|
Is there any performance differences using the reflection API instead of get_class_parent? |
|
@mjauvin I can tell you that so far, I have not been able to find a way to use any sort of @LukeTowers I haven't timed it yet, but I'm going to assume there's a small performance hit. But as above, it may be the only way to do it if we want to allow the magic methods of parent classes to still be fallen back upon. |
|
@bennothommo and using |
|
@mjauvin It didn't when I tried it out, and it didn't in the test cases on the other PR I mentioned. |
|
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
|
@bennothommo are you able to fix the code analysis error? |
|
@LukeTowers done |
This uses Reflection to instead determine the parent class and available magic methods to pass through to. In order to prevent infinite looping (which could've potentially been a problem before), it will also ignore any "extendable" classes when determining the parent.
Also fixed some tests that were using undefined class properties, and were also throwing deprecation errors.
Replaces #152