Skip to content

Comments

Restore previous tests order#159

Merged
LukeTowers merged 3 commits intodevelopfrom
fix-relations
Oct 19, 2023
Merged

Restore previous tests order#159
LukeTowers merged 3 commits intodevelopfrom
fix-relations

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Oct 18, 2023

No description provided.

@mjauvin mjauvin added this to the v1.2.4 milestone Oct 18, 2023
@mjauvin mjauvin self-assigned this Oct 18, 2023
@mjauvin mjauvin marked this pull request as draft October 18, 2023 03:31
@mjauvin
Copy link
Member Author

mjauvin commented Oct 18, 2023

I couldn't reproduce the errors while calling $model->{'relation'} for all relation types with REAL models... I am going to assume the test models are missing something and merge this fix.

@mjauvin mjauvin marked this pull request as ready for review October 18, 2023 22:03
@LukeTowers
Copy link
Member

What is that conditional supposed to be checking for?

@mjauvin
Copy link
Member Author

mjauvin commented Oct 19, 2023

What is that conditional supposed to be checking for?

Not entirely sure, to be honest.

@LukeTowers
Copy link
Member

Not entirely sure, to be honest.

I don't really like that answer 😜 time to go digging through the history I guess 😂

@LukeTowers LukeTowers merged commit 2941ef4 into develop Oct 19, 2023
@LukeTowers LukeTowers deleted the fix-relations branch October 19, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants