Allow for YAML rendering pre/post processing.#53
Merged
LukeTowers merged 4 commits intowip/1.2from Dec 17, 2021
Merged
Conversation
This is a BC break since it changes the contract. Classes implementing the "Winter\Storm\Parse\Processor\Contracts\YamlProcessor" interface should instead extend the "Winter\Storm\Parse\Processor\YamlProcessor" abstract to maintain parity with the interface.
Member
|
How does this interact with #21 and the related PR? |
Member
Author
|
It should be entirely compatible with that PR (besides changing the processor to extend the abstract class as opposed to implementing the interface). These new methods are for rendering though, so while that PR ensures that our older version files can still be read, this will allow us to ensure that the YAML files are correctly written as well. |
Member
|
@bennothommo what's the status of this? |
Member
Author
|
@LukeTowers it should be ready to go. |
Member
|
@bennothommo looks like the tests need to be fixed for this PR |
Member
Author
|
@LukeTowers fixed up the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a BC break since it changes the contract. Classes implementing the
Winter\Storm\Parse\Processor\Contracts\YamlProcessorinterface should instead extend theWinter\Storm\Parse\Processor\YamlProcessorabstract to maintain parity with the interface.This change is in preparation of a change that I intend to make for the Builder plugin to ensure that the
version.yamluses quoted version keys when generating the migrations.