Fix closure listener with parameters as reference#69
Merged
LukeTowers merged 6 commits intowintercms:wip/1.2from Feb 23, 2022
mjauvin:fix-closure-listener
Merged
Fix closure listener with parameters as reference#69LukeTowers merged 6 commits intowintercms:wip/1.2from mjauvin:fix-closure-listener
LukeTowers merged 6 commits intowintercms:wip/1.2from
mjauvin:fix-closure-listener
Conversation
…ference the internal closure when called
… gets passed by reference
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behavior creates a "regular" Closure for the listener we already wrap in a SerializedClosure (in Laravel's Events::Dispatcher::makeListener() method).
This PR delays creating the SerializedClosure on the initial listener and waits for the Closure returned by Laravel's makeListener() method before wrapping it into a SerializedClosure.