Use extension if provided in resizer options#74
Closed
mjauvin wants to merge 3 commits intowintercms:wip/1.2from
mjauvin:resizer-use-extension
Closed
Use extension if provided in resizer options#74mjauvin wants to merge 3 commits intowintercms:wip/1.2from mjauvin:resizer-use-extension
mjauvin wants to merge 3 commits intowintercms:wip/1.2from
mjauvin:resizer-use-extension
Conversation
Member
Author
|
@LukeTowers any reason against merging this? Converting a jpg to a webp won't work without this fix. |
LukeTowers
reviewed
Mar 24, 2022
LukeTowers
reviewed
Mar 24, 2022
LukeTowers
reviewed
Mar 24, 2022
|
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
Member
Author
|
@LukeTowers why did you close this? |
Member
|
@mjauvin I think these were automatically closed when Luke deleted the |
Member
|
@bennothommo is correct, it was unintentionally auto closed. |
LukeTowers
pushed a commit
that referenced
this pull request
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to allow converting images to other formats (e.g. webp). Otherwise the resulting file will have the correct extension but the wrong image format.
Replaces #9 since the original repo got deleted.
The following code can be used as a workaround in the meantime: