Add unit test for overriden to() method#88
Closed
mjauvin wants to merge 1 commit intowintercms:developfrom
mjauvin:test-to-method-against-base
Closed
Add unit test for overriden to() method#88mjauvin wants to merge 1 commit intowintercms:developfrom mjauvin:test-to-method-against-base
mjauvin wants to merge 1 commit intowintercms:developfrom
mjauvin:test-to-method-against-base
Conversation
Contributor
|
Although added test looks valid and useful, the actual result of failed cases is the same, I mean, if you decode Problems starts with |
Member
Author
|
@arvislacis Yes, I am aware of this, but @LukeTowers needed a test case that showed the issue in order to fix the problem. |
LukeTowers
added a commit
that referenced
this pull request
Jun 25, 2022
Fixes wintercms/wn-translate-plugin#36, replaces #88. Credit to @mjauvin for the initial test case.
Member
|
Merged in 32df10c |
71 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: wintercms/wn-translate-plugin#36 (comment)