Skip to content

Comments

Add unit test for overriden to() method#88

Closed
mjauvin wants to merge 1 commit intowintercms:developfrom
mjauvin:test-to-method-against-base
Closed

Add unit test for overriden to() method#88
mjauvin wants to merge 1 commit intowintercms:developfrom
mjauvin:test-to-method-against-base

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Jun 15, 2022

@mjauvin mjauvin requested a review from LukeTowers June 15, 2022 14:43
@mjauvin mjauvin self-assigned this Jun 15, 2022
@arvislacis
Copy link
Contributor

Although added test looks valid and useful, the actual result of failed cases is the same, I mean, if you decode https://www.example.com/path?array%5B%5D=v1&array%5B%5D=v2 then it's equal to https://www.example.com/path?array[]=v1&array[]=v2

Problems starts with https://www.example.com/path?array[0]=v1&array[1]=v2 which is then interpretated as https://www.example.com/path?array[0][]=v1&array[1][]=v2

@mjauvin
Copy link
Member Author

mjauvin commented Jun 15, 2022

@arvislacis Yes, I am aware of this, but @LukeTowers needed a test case that showed the issue in order to fix the problem.

LukeTowers added a commit that referenced this pull request Jun 25, 2022
@LukeTowers
Copy link
Member

Merged in 32df10c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants