Restore Laravel 6 behavior to public visibility for local driver#92
Merged
LukeTowers merged 5 commits intowip/1.2from Jul 8, 2022
Merged
Restore Laravel 6 behavior to public visibility for local driver#92LukeTowers merged 5 commits intowip/1.2from
LukeTowers merged 5 commits intowip/1.2from
Conversation
LukeTowers
reviewed
Jul 4, 2022
Member
|
@driesvints if you have a moment do you recall or have a link to the reasoning behind changing the default from public to private for the local Flysystem driver in Laravel 9? |
|
@LukeTowers that got changed in Flysystem v3 so you'll have to ask them. Afaik it's a more safe and sensible default. You should always use the same user to handle files. |
Member
|
@driesvints I agree in theory that it's more safe default, the PHP user can access the files but the problem comes when the webserver user wants to fetch them to respond to requests, which is the default used by a few providers, ServerPilot & Cleavr for example. Any recommendations for how to handle that use case? |
|
Not really sorry.. |
Member
|
Thanks anyways :) |
LukeTowers
reviewed
Jul 8, 2022
LukeTowers
reviewed
Jul 8, 2022
LukeTowers
reviewed
Jul 8, 2022
LukeTowers
reviewed
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wintercms/winter#503
@LukeTowers @bennothommo @jaxwilko
Here's my preferred solution to this.