Conversation
Member
Author
|
@mjauvin could you see if this fixes the issue for you? It's only a temporary solution but it's better than nothing :) |
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
@bennothommo while I'd somewhat prefer using concrete classes over facades in general to some extent that isn't a fully workable solution for all our users given that they could very easily have been using their own functions defined from facades, so the underlying issue would still not be fixed. |
Member
|
Fair call. It's a moot point now anyway, as it looks like it's being fixed at the PHP lang level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a hack that fixes an exception thrown during twig rendering.
This should be removed once @bennothommo's PR is merged.