When deleting and restoring an admin, UserGroups relations are not restored

[xyz1123581321]

Winter CMS Build

1.1

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

I want to prevent User Group deletion when an admin is deleted. The records exists but not the relations. After restoring the admin, groups are not restored.

Tried with changing the core User.php file with:

public $belongsToMany = [
        'groups' => [UserGroup::class, 'table' => 'backend_users_groups', 'softDelete' => true]
];

Doesnt help. I even tried to modify SoftDelete trait and commented out the methods for deleting the relations, doesnt help either.

Steps to replicate

.

Workaround

No response

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[arvislacis]

I can confirm that this issue exists and maybe we also need to check if this problem isn't much bigger - because it looks like when soft deleting main model which has SoftDelete trait (in this case User model and backend_users table) then all related entries in Many To Many table (in this case UserGroup and backend_users_groups) are deleted automatically although if we look at https://wintercms.com/docs/database/relations#detailed-relationships then by default it should be 'delete' => false.

I was also experimenting to manually set delete and/or detach on $belongsToMany in User and UserGroup models (in various variations) but nothing changed this previously described behaviour.

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in this issue for the last 6 months.
If this issue is still relevant or you would like to see it actioned, please respond within 3 days.
If this issue is critical for your business, please reach out to us at wintercms@luketowers.ca.

[LukeTowers]

@arvislacis are you able to submit a PR to the test plugin reproducing the issue?

[arvislacis]

@LukeTowers I may try to implement some tests in test plugin although, IMHO, this issue would need back-end related/automated tests more than UI ones...

Overall the problem is that existing pivot table backend_users_groups doesn't have deleted_at column or similar mechanism to implement soft delete state in many-to-many relation. But I see that Laravel has been having problems with this, for example, https://laracasts.com/discuss/channels/general-discussion/soft-deletes-with-pivot-table

[arvislacis]

A step-to-step guide how to reproduce this:

1. Go to the Settings -> Administrators;
2. Create new user (testuser etc.) and add it to group, for example, "Owners" group;

3. Open newly created user (testuser) record and delete it from UI (soft delete on User model will happen);
4. Return to user list, select to "Show deleted" and then restore the deleted user (testuser) account;
5. If you then open testuser record and investigate "Groups" tab then all checkboxes are empty (group relationshios has been deleted with step 3).