Winter 1.2 not using SMTP settings from database

[tintong]

Winter CMS Build

1.2

PHP Version

8.0

Database engine

MySQL/MariaDB

Plugins installed

Winter.Pages, Winter.Blog, Winter.User

Issue description

Since upgrading to Winter 1.2 from the previous version, emailing via SMTP has not worked.

The error message when emailing has always been:
Expected response code "250/251/252" but got code "550", with message "550 5.7.1 Relaying denied".

I've looked into why and I have found that the email settings entered in the Winter backend, saved to the database, are not being used when actually emailing within Winter.

This can be tested by pressing the "Send test message" button in the "Mail configuration" backend section.

Upon looking at the code, when "createSmtpTransport($config)" in MailManager.php from laravel is called, the values it is looking for are $config['host'], $config['username'], $config['password'], $config['port'].

Ref: https://github.com/laravel/framework/blob/8156743f644fb4597b63261a3fda4e4d6ca49a78/src/Illuminate/Mail/MailManager.php#L163-L183

However, when "applyConfigValues()" in MailSetting.php is called, both the values from config/mail.php and the database are combined.

Ref: https://github.com/wintercms/winter/blob/develop/modules/system/models/MailSetting.php#L86-L118

The config values that get passed to laravel are in this format:
Array ( [driver] => smtp [host] => smtp.mailgun.org [port] => 587 [from] => Array ( [address] => mailaddress [name] => Winter CMS ) [encryption] => tls [username] => [password] => [sendmail] => /usr/sbin/sendmail -bs [default] => smtp [mailers] => Array ( [smtp] => Array ( [host] => smtp.office365.com [port] => 587 [username] => mailaddress [password] => password [encryption] => tls ) ) )

It seems that laravel then only uses the config values from config/mail.php instead of the database to make the Smtp connection.

Steps to replicate

Leave the config/mail.php as default from the Winter installation.
Add Smtp settings into the Mail configuration section in the Winter CMS and click on "Send Test email".
Error message "Expected response code "250/251/252" but got code "550", with message "550 5.7.1 Relaying denied"." is then presented.

Workaround

As a temporary workaround, put your Smtp configuration values into config/mail.php.

[tintong]

I'd be happy to continue helping with this, just need some more pointers to look at please.

[mjauvin]

I tried replicating this with your procedure and I couldn't. The proper config gets passed from what's provided in the form, and mail gets sent properly. I had no config in the config/mail.php (other than default values)

[mjauvin]

I also added trace_log($config) call here and I got the proper config as expected:

https://github.com/laravel/framework/blob/8156743f644fb4597b63261a3fda4e4d6ca49a78/src/Illuminate/Mail/MailManager.php#L171

[tintong]

Thank you for helping.

The only other plugin I have but not enabled is the Gmail email sending one.

I'll try again today.

[mjauvin]

It's possible the gmail plugin is interfering, try removing/disabling it.

[tintong]

I've removed the gmail plugin and deleted the files.
Then tested it again and the config that comes in to the "createSmtpTransport" function still points to "smtp.mailgun.org" which is what is in the config/mail.php file.

What else might it be please?

[tintong]

Does trace_log($config); echo an output automatically or should it be done separately?

[mjauvin]

It should work, please show how you debug this.

Also, show the output of composer show winter*

[mjauvin]

Does trace_log($config); echo an output automatically or should it be done separately?

it sends the output to your /storage/logs/system.log file

[tintong]

I've added "trace_log($config)" to the "resolve" function in winter\storm\src\Mail\MailManager.php
The trace_log() command is right after $config = $this->getConfig($name);
The output is:

[2022-07-23 17:34:37] development.INFO: Array
(
[host] => smtp.office365.com
[port] => 587
[username] => emailadrress
[password] => password
[encryption] => tls
)

I then added the same function into the "createSmtpTransport(array $config)" function within the laravel MailManager.php file.

The output is:
[2022-07-23 17:42:55] development.INFO: Array
(
[driver] => smtp
[host] => smtp.mailgun.org
[port] => 587
[from] => Array
(
[address] => emailaddress
[name] => Winter CMS
)

[encryption] => tls
[username] => 
[password] => 
[sendmail] => /usr/sbin/sendmail -bs
[default] => smtp
[mailers] => Array
    (
        [smtp] => Array
            (
                [host] => smtp.office365.com
                [port] => 587
                [username] => emailaddress
                [password] => password
                [encryption] => tls
            )

    )

)

the output for "composer show winter*" is:

winter/storm v1.2.0 Winter CMS Storm Library
winter/wn-backend-module v1.2.0 Backend module for Winter CMS
winter/wn-blog-plugin v2.0.2 Blog plugin for Winter CMS
winter/wn-cms-module v1.2.0 CMS module for Winter CMS
winter/wn-pages-plugin v2.0.2 Pages plugin for Winter CMS
winter/wn-system-module v1.2.0 System module for Winter CMS
winter/wn-user-plugin v2.0.0 User plugin for Winter CMS