Conversation
Co-authored-by: Luke Towers <github@luketowers.ca>
LukeTowers
added
Status: In Progress
enhancement
|
Nice! |
|
Minor point, but as developers in general we should probably move away from white/black list terminology towards include/exclude instead as it's more clear to newcomers and less controversial. I would name the field "Allowed IP addresses" with the visual comment "IP addresses that are permitted to view the site while maintenance mode is active". |
|
How about adding the line "Your ip ..." before the list of allowed ip addresses, where to display the user's current ip address and the button "Add ip to the allowed list" if the ip is not in the allowed list? And is it possible to do this functionality the same way to access the backend? Store only an array with allowed IP addresses in the |
@WebVPF that could easily be achieved via a plugin |
jaxwilko
added
the
needs review
|
This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days. |
github-actions
bot
added
the
stale
LukeTowers
removed
the
stale
|
Just to note, as I'm having a look into it now, but this functionality does not support trusted proxies currently. It's using the proxy's IP in the lookup for allowed IPs. |
bennothommo
added
Status: Revision Needed
and removed
needs review
|
My previous comment can be ignored. It seems to be something intrinsic to Gitpod in not forwarding on my actual IP - it doesn't happen on other proxies. |
* develop: (25 commits) Support embedded data URIs in the list image column type Make some adjustments to the readme content Update banner in readme Add new GitHub banner Documentation with icons (#347) Limit options shown in group filter, apply scope when retrieving filtered options Add Exception on wrong relation type in relation formwidget (#334) Redesigned color picker widget (#324) Add winter:test command (#202) Use the correct backend timezone config key (#337) Get changelog only of the current branch Fix Markdown editor sizing issue on Chrome. Check overrides for parent locale when compiling language files (#242) Fixing commas in English translation files (#305) Added Latvian translations for Allowed IP messages (#304) Add missing filter translations (#303) Clean up newlines Update Russian language (#302) Fix issue present in overriding RelationController partials using the default code Maintenance Allowed IP list (#147) ...
7 participants
This PR adds support for whitelisting IP addresses to be allowed to visit the frontend while in maintenance mode. This is really useful when you have a site in maintenance mode to avoid being indexed by crawlers or for staging sites where automated tools need to be ran.
Uses
Request::ip()under the hood for IP detection.