Add support for the Laravel asset() helpers#426
Merged
LukeTowers merged 5 commits intodevelopfrom Feb 13, 2022
Merged
Conversation
LukeTowers
reviewed
Jan 31, 2022
LukeTowers
reviewed
Jan 31, 2022
LukeTowers
reviewed
Jan 31, 2022
LukeTowers
added
Status: In Progress
maintenance
LukeTowers
changed the title
Member
I cannot "yes" this enough. |
Member
I agree with that and once #404 is merged then the main blocker to that in the past will be able to be dealt with and we can have a configuration system that works well for newbies and pros. I'm excited for it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some of the Laravel defaults into Winter's configs.
IMHO we should consider
env()calls for every config that Laravel uses them for, which will be possible once #404 is merged. @bennothommo @LukeTowers thoughts?