[WIP] Revise class loader

modules/backend/ServiceProvider.php

@@ -20,6 +20,8 @@ class ServiceProvider extends ModuleServiceProvider
      */
     public function register()
     {
+        parent::register();
+
         $this->registerConsole();
         $this->registerMailer();
         $this->registerAssetBundles();

modules/cms/ServiceProvider.php

@@ -36,6 +36,8 @@ class ServiceProvider extends ModuleServiceProvider
      */
     public function register()
     {
+        parent::register();
+
         $this->registerConsole();
         $this->registerTwigParser();
         $this->registerAssetBundles();

modules/system/ServiceProvider.php

@@ -38,6 +38,8 @@ class ServiceProvider extends ModuleServiceProvider
      */
     public function register()
     {
+        parent::register();
+
         $this->registerSingletons();
         $this->registerPrivilegedActions();
 
@@ -60,7 +62,14 @@ public function register()
          * Register other module providers
          */
         foreach (Config::get('cms.loadModules', []) as $module) {
-            if (strtolower(trim($module)) != 'system') {
+            $moduleLower = strtolower(trim($module));
+            $serviceProviderPath = base_path("modules/$moduleLower/ServiceProvider.php");
+            if (
+                strtolower(trim($module)) !== 'system'
+                && file_exists($serviceProviderPath)
+            ) {
+                // Load and register the module's ServiceProvider
+                require_once $serviceProviderPath;
                 App::register('\\' . $module . '\ServiceProvider');
             }
         }

modules/system/classes/PluginManager.php

@@ -177,6 +177,10 @@ public function loadPlugin($namespace, $path)
             $classObj->disabled = true;
         }
 
+        // Register the plugin with the autoloader
+        $pluginNamespace = Str::before(get_class($classObj), '\\Plugin') . '\\';
+        $this->app->make(ClassLoader::class)->autoloadPackage($pluginNamespace, $path . '/');
+
         $this->plugins[$classId] = $classObj;
         $this->pathMap[$classId] = $path;
         $this->normalizedMap[strtolower($classId)] = $classId;
@@ -292,7 +296,7 @@ public function registerPlugin($plugin, $pluginId = null)
             foreach ($replaces as $replace) {
                 $replaceNamespace = $this->getNamespace($replace);
 
-                App::make(ClassLoader::class)->addNamespaceAliases([
+                $this->app->make(ClassLoader::class)->addNamespaceAliases([
                     // class_alias() expects order to be $real, $alias
                     $this->getNamespace($pluginId) => $replaceNamespace,
                 ]);

modules/system/providers.php

@@ -1,5 +1,8 @@
 <?php
 
+// Ensure the System ServiceProvider class is available
+require_once __DIR__ . DIRECTORY_SEPARATOR . 'ServiceProvider.php';
+
 return [
 
     /*

tests/bootstrap.php

@@ -15,7 +15,3 @@
 );
 
 $loader->register();
-$loader->addDirectories([
-    'modules',
-    'plugins'
-]);