Skip to content

Comments

[WIP] 1.2 Test Split - Modules own tests#581

Merged
LukeTowers merged 22 commits intowip/1.2from
wip/1.2-test-split
Jun 22, 2022
Merged

[WIP] 1.2 Test Split - Modules own tests#581
LukeTowers merged 22 commits intowip/1.2from
wip/1.2-test-split

Conversation

@jaxwilko
Copy link
Member

@jaxwilko jaxwilko commented Jun 21, 2022 •
edited
Loading

@LukeTowers told me to...

This PR splits out tests into their related modules, allowing for each module to be targeted using the winter:test command. Added to this is also proper namespacing and a bunch of minor bug fixes and tweaks.

@jaxwilko jaxwilko changed the base branch from develop to wip/1.2 June 21, 2022 04:45
@jaxwilko jaxwilko changed the title Wip/1.2 test split [WIP] 1.2 Test Split - Modules own tests Jun 21, 2022
@jaxwilko jaxwilko added enhancement PRs that implement a new feature or substantial change maintenance PRs that fix bugs, are translation changes or make only minor changes labels Jun 21, 2022
LukeTowers
LukeTowers reviewed Jun 21, 2022
View reviewed changes
LukeTowers
LukeTowers reviewed Jun 21, 2022
View reviewed changes
LukeTowers
LukeTowers reviewed Jun 21, 2022
View reviewed changes
@bennothommo
Copy link
Member

bennothommo commented Jun 21, 2022

Hey guys, 2 thoughts on this -

LukeTowers
LukeTowers requested changes Jun 21, 2022
View reviewed changes
@LukeTowers
Copy link
Member

LukeTowers commented Jun 21, 2022

@bennothommo

  1. Yes, we are. Any existing projects will still have the original tests folder and they can keep using that if they want.
  2. I want the tests folders for the modules distributed via Composer, that way the winter:test command can always be used and our testing suite can stay up to date with the rest of the platform. Right now if we make any changes to the testing suite or the base classes the only way users can get those changes is by manually downloading them to update their project tests folder.

@bennothommo
Copy link
Member

bennothommo commented Jun 21, 2022

@bennothommo

1. Yes, we are. Any existing projects will still have the original tests folder and they can keep using that if they want.

As long as that doesn't create any conflicts, all good!

2. I want the tests folders for the modules distributed via Composer, that way the `winter:test` command can always be used and our testing suite can stay up to date with the rest of the platform. Right now if we make any changes to the testing suite or the base classes the only way users can get those changes is by manually downloading them to update their project tests folder.

I suppose it will be handy to not have to instruct people to download or updates their test folders anymore.

@jaxwilko
[WIP] Split Test - 1.2 - PluginManager lower case internal IDs (#583)
fba6446 
This modifies the plugin manager to internally treat plugin identifiers as lower case strings, only transforming them to their normalized versions when requested by methods like getPlugins() & getAllPlugins().

The idea behind this is that it provides a much simpler way to internally handle checking, especially for plugin replacement where casing could cause issues.

Replaces #576. Fixes #575.
@jaxwilko
Copy link
Member Author

jaxwilko commented Jun 22, 2022

Removed global func/const imports in d1ff094

@LukeTowers LukeTowers merged commit 7fe167c into wip/1.2 Jun 22, 2022
@LukeTowers LukeTowers deleted the wip/1.2-test-split branch June 22, 2022 00:30
@LukeTowers LukeTowers mentioned this pull request Jun 25, 2022
Merged
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees

No one assigned

Labels

enhancement PRs that implement a new feature or substantial change maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaxwilko @bennothommo @LukeTowers