Skip to content

Fix twig environment #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjauvin wants to merge 3 commits into from
Closed

Fix twig environment #593

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9cd7e1
fix twig environment; credit to @RomainMazB
mjauvin Jul 3, 2022
101c68b
document the *hack*
mjauvin Jul 4, 2022
e6da3b3
Merge branch 'wip/1.2' into wip/fix-twig-context
mjauvin Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/cms/classes/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,10 @@ protected function postProcessResult($page, $url, $content)
protected function initTwigEnvironment()
{
$this->twig = App::make('twig.environment.cms');
// Ensure that $this['controller'] is available at all times in the base Twig context
// so that CMS Twig functions (in Cms\Twig\Extension) work inside of Macros
// @see https://github.com/wintercms/winter/issues/578
$this->twig->addGlobal('this', ['controller' => $this]);
}

/**
Expand Down