Update EditorConfig link#602
Merged
LukeTowers merged 2 commits intowintercms:developfrom Jul 14, 2022
WebVPF:vscode
Merged
Conversation
Member
|
I think my only hesitation on including this is that I don't want to enforce a coding style on people writing their own projects. We use @wintercms/maintainers any thoughts on this? |
bennothommo
added
needs response
Member
|
What's the UX for this? VSCode just asks if you want to install recommended extensions? |
Member
|
@LukeTowers that's correct. |
WebVPF
changed the title
Contributor
Author
|
Ben is right. The recommendation has been removed. |
LukeTowers
added
Status: Completed
and removed
needs response
LukeTowers
added a commit
that referenced
this pull request
Jul 15, 2022
* develop: (65 commits) Update maximum supported PHP version for 1.1 (#603) Update EditorConfig link (#602) Apply consistent path normalisation to fix Windows test Fix view maker unit test for Windows Outputs time respecting backend preferences (#572) Rebuild Snowboard agian Revert "Rebuild Snowboard" Rebuild Snowboard Allow a string selector for the form in a request Use correct line breaks for Windows tests Backport ViewMaker tests from 1.2 branch farsi spelling correction (#579) Add Winter 1.2 as version option in bug report Adjust early termination of requests from success/error Increase stale check to 6 months Let composer resolve current php process in scripts (#563) Fix track input not keeping timeout Add jQuery AJAX prefilter as early as possible Add additional debugging for errors thrown in events Abstract Snowboard plugin constructors and destructors (#561) ... # Conflicts: # composer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a useful extension that should be recommended to users who do not have it installed.
https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig