Skip to content

Comments

Uncaught ReferenceError: gtag is not defined#778

Merged
LukeTowers merged 1 commit intowintercms:developfrom
cubicltd:fix-tailwind-js-theme-stub
Nov 28, 2022
Merged

Uncaught ReferenceError: gtag is not defined#778
LukeTowers merged 1 commit intowintercms:developfrom
cubicltd:fix-tailwind-js-theme-stub

Conversation

@matteotrubini
Copy link
Contributor

@matteotrubini matteotrubini commented Nov 27, 2022

If gtag() is currently undefined an error is raised.

@matteotrubini
gtag() check
af09a1a 
If gtag() is undefined an error is raised.
@what-the-diff
Copy link

what-the-diff bot commented Nov 27, 2022

  • The if statement was changed to check for the type of gtag.
  • If it is not a function, then we log that GoogleAnalytics is not present in the console.

@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Nov 28, 2022
@LukeTowers LukeTowers merged commit 9b2282b into wintercms:develop Nov 28, 2022
@LukeTowers LukeTowers added this to the v1.2.2 milestone Nov 28, 2022
LukeTowers added a commit that referenced this pull request Dec 8, 2022
@LukeTowers
Merge branch 'develop' into wip/child-theme-autodatasource-caching
fe5f754 
* develop:
  Fix issue with autoloading modules (#792)
  Add support for icon picker (#725)
  Classloader improvements (#779)
  Update Markdown content test
  Improved Ukrainian translation (#766)
  Add AJAX form validation to Snowboard (#777)
  Improve theme scaffolding (#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees

No one assigned

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

v1.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@matteotrubini @LukeTowers