Skip to content

Comments

winter 1.2.8 support#7

Merged
LukeTowers merged 33 commits intomainfrom
wip/winter-1.2.8-support
Jul 23, 2025
Merged

winter 1.2.8 support#7
LukeTowers merged 33 commits intomainfrom
wip/winter-1.2.8-support

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented May 2, 2025

Depends on wintercms/winter#1312

Update Winter.Location to use formcontroller behavior's default views.

Copy link
Member

@LukeTowers LukeTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending merge of wintercms/winter#1312 and release of 1.2.8

@mjauvin
Copy link
Member Author

mjauvin commented May 28, 2025

What are all those errors @LukeTowers

@LukeTowers
Copy link
Member

@mjauvin not sure, will have to check later. I thought they'd just be because of the composer dependency not being a valid version but they don't look like that.

@LukeTowers
Copy link
Member

@mjauvin do you have a minute to take a look at the test failures? Seems like there's something going wrong with the actual test logic here.

@mjauvin
Copy link
Member Author

mjauvin commented Jul 16, 2025

@LukeTowers looks like it doesn't like the dependency on "winter/wn-backend-module": "~1.2.8" you added.

@mjauvin
Copy link
Member Author

mjauvin commented Jul 17, 2025

I don't know man, makes no sense to me.

@LukeTowers
Copy link
Member

@LukeTowers looks like it doesn't like the dependency on "winter/wn-backend-module": "~1.2.8" you added.

@mjauvin you were correct. The setup winter action puts the overall project at dev-develop, which meant that the plugin's dependencies weren't able to be loaded because of the 1.2.8 requirement. I changed it to 1.2.8|dev-develop and it's working now.

@LukeTowers LukeTowers merged commit dc07435 into main Jul 23, 2025
4 checks passed
@LukeTowers LukeTowers deleted the wip/winter-1.2.8-support branch July 23, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants