Conversation
LukeTowers
left a comment
There was a problem hiding this comment.
Approved pending merge of wintercms/winter#1312 and release of 1.2.8
|
What are all those errors @LukeTowers |
|
@mjauvin not sure, will have to check later. I thought they'd just be because of the composer dependency not being a valid version but they don't look like that. |
|
@mjauvin do you have a minute to take a look at the test failures? Seems like there's something going wrong with the actual test logic here. |
|
@LukeTowers looks like it doesn't like the dependency on |
|
I don't know man, makes no sense to me. |
@mjauvin you were correct. The setup winter action puts the overall project at dev-develop, which meant that the plugin's dependencies weren't able to be loaded because of the 1.2.8 requirement. I changed it to 1.2.8|dev-develop and it's working now. |
Depends on wintercms/winter#1312
Update Winter.Location to use formcontroller behavior's default views.