Draft
Conversation
Member
Author
|
Example screenshots being taken by the Dusk tests:
|
Member
|
Is there anyway that we could have some sort of visual diff / fixtures to compare against to make it easier to identify changes in the screenshots? |
Member
Author
|
@LukeTowers BrowserStack has the "Percy" section which I believe does exactly that. I'd just have to figure out how to get images generated in Dusk sent through to there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will set up multiple Dusk tests for the Test plugin, giving us a comprehensive suite of acceptance tests with the goal of testing some front-end functionality of the Backend that unit tests can't properly test. As an added benefit, this is also giving our Dusk plugin a good test case as well.
Another goal is to set up a gallery of screenshots that cover most, if not all, of the elements one would expect to find in the Backend, which will be useful for the main repo when PRs are submitted that change the look or functionality of widgets, elements or the entire backend.