Skip to content

Comments

feat: auto connect to ws when server have no fcm#3901

Draft
MohamadJaara wants to merge 6 commits intodevelopfrom
mo/feat/auto-connect-to-ws-when-server-have-no-fcm
Draft

feat: auto connect to ws when server have no fcm#3901
MohamadJaara wants to merge 6 commits intodevelopfrom
mo/feat/auto-connect-to-ws-when-server-have-no-fcm

Conversation

@MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

Test Results

0 tests   - 4 425   0 ✅  - 4 308   0s ⏱️ - 5m 27s
0 suites  -   736   0 💤  -   117 
0 files    -   736   0 ❌ ±    0 

Results for commit 4033c7e. ± Comparison against base commit 24c67c5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.80%. Comparing base (24c67c5) to head (4033c7e).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...ogic/feature/notificationToken/PushTokenUpdater.kt 59.09% 6 Missing and 3 partials ⚠️
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 33.33% 2 Missing and 2 partials ⚠️
...ire/kalium/logic/data/session/SessionRepository.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3901      +/-   ##
===========================================
+ Coverage    59.78%   59.80%   +0.02%     
===========================================
  Files         1920     1920              
  Lines        60136    60196      +60     
  Branches      6519     6528       +9     
===========================================
+ Hits         35951    36003      +52     
- Misses       21185    21189       +4     
- Partials      3000     3004       +4     
Files with missing lines Coverage Δ
...ium/logic/data/notification/PushTokenRepository.kt 0.00% <ø> (ø)
...ire/kalium/logic/data/session/SessionRepository.kt 14.28% <80.00%> (+14.28%) ⬆️
.../persistence/daokaliumdb/ServerConfigurationDAO.kt 52.23% <33.33%> (-0.48%) ⬇️
...ogic/feature/notificationToken/PushTokenUpdater.kt 75.67% <59.09%> (-17.66%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c67c5...4033c7e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants