Skip to content

Comments

feat: implement changelog sync events and payloads for nomad devices#3907

Draft
MohamadJaara wants to merge 1 commit intomo/nomad-devices/feat/persistence-events-delete-readreceiptfrom
mo/nomad-devices/feat/select-stream-of-events-from-DB
Draft

feat: implement changelog sync events and payloads for nomad devices#3907
MohamadJaara wants to merge 1 commit intomo/nomad-devices/feat/persistence-events-delete-readreceiptfrom
mo/nomad-devices/feat/select-stream-of-events-from-DB

Conversation

@MohamadJaara
Copy link
Member

PR Submission Checklist for internal contributors

  • The PR Title
    • conforms to semantic commit style
    • contains a JIRA issue number like SQPIT-764 (replace SQPIT-XXXX)
    • answers what this PR will do

Suggested title:
feat(remote-backup): expose proto-ready changelog event stream from message query #SQPIT-XXXX

  • The PR Description
    • filled relevant parts

What's new in this PR?

Disclaimer

Most of the diff is mapper + data class reshaping, so PR size looks bigger than the actual behavior change.

Issues

  • We needed one convenient stream/query returning the latest changelog events already enriched for proto encoding.
  • Consumers needed typed events instead of a single generic row model.

Solutions

  • Added/used a compact query for latest pending changelog events with minimal joins (no MessageDetails view).
  • Exposed results as sealed ChangeLogSyncEvent types.
  • Extracted mapping into RemoteBackupChangeLogMapper.
  • Enforced non-null message_id for message-scoped event mapping.

Dependencies

None.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage

  • I have added/updated automated tests

How to Test

Notes


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any sort of configuration variable was introduced by this PR, it has been added to the relevant docs and CI jobs have been updated.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant