Add analysis of Marlin firmware history for Creality CR-30 3DPrintMill #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also propose dropping some customizations from the community firmware. After exploring first-commits and merge-bases, I've learned that some changes don't compile, and some might have been for prototype models. I'm recommending that we remove the changes that cannot be built and tested, and re-evaluate the remaining changes for safety and recency.
wireddown
commented
Jun 5, 2023
Mimic CR-30 Users at time of pull upstream fw commit -- `73b8320e9caac23873169c8e10344f2f8060b389` upstream cfg commit - `0a8dfe5594ca981428c9adf76068e3cbe425c3ba`
From CR30-Users commit 4c8cd975d6
When `MIN_SOFTWARE_ENDSTOP_Y` is not defined, then the value for `Y_MIN_POS` is ignored. The Y axis can lower infinitely as far as the firmware is concerned. Set `Y_MIN_POS` to 0 so that during the machine leveling, setting the new home position makes true home match Y == 0.
wireddown
commented
Jun 7, 2023
- I measured Y max as 240 mm on my machine - The E position indcator on the LCD replaces the X Y positions
Owner
Author
|
I did some in-depth testing with my CR-30 and it showed that two items I recommended to remove should be kept instead:
I updated the mark down and the diff-sketches to reflect this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyze CR-30 Marlin Firmware History
This PR
After exploring first-commits and merge-bases, I've learned that some changes don't compile, and some might have been for prototype models. I'm recommending that we remove the changes that cannot be built and tested, and re-evaluate the remaining changes for safety and recency.
Headline removals
More in the markdown 🤓
BELT_KINEMATICS_DEVconfiguration optionBundled as rework-required
Z_MIN_PROBE_PINfromPA5toPB1PB0,PB1,PA13,PA14