Allow constraints with world entity #2782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vurvdev
suggested changes
Oct 5, 2023
vurvdev
suggested changes
Oct 5, 2023
|
|
||
| local function checkEnts(self, ent1, ent2) | ||
|
|
||
| if not (ent1 and ent2) then return self:throw("Invalid entity (nil)!", false) end |
There was a problem hiding this comment.
The (nil) isn't necessary, E2 users won't know what that is so it'll just confuse them.
I think not ent1 or not ent2 would also be more clear logic
| if not (ent1 and ent2) then return self:throw("Invalid entity (nil)!", false) end | ||
|
|
||
| if not ent1:IsWorld() then | ||
| if not IsValid(ent1) then return self:throw("Invalid entity!", false) end |
There was a problem hiding this comment.
can change this to ent1:IsValid() since you added the nil check at the top
vurvdev
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows E2 constraintcore to constraint to the world entity despite ownership.