fix: use correct datastore location in test environment#12640
Merged
Conversation
🦋 Changeset detectedLatest commit: d5e8a27 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #12640 will degrade performances by 20.49%Comparing Summary
Benchmarks breakdown
|
ematipico
approved these changes
Dec 5, 2024
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The content layer needs to know if it is running in dev, so that it knows whether to find the datastore in the
.astrofolder (so it can be watched for changes) or innode_modules(so it is cached between builds in production environments). Previously it was incorrectly detecting this in the Vite plugin by using theisProductionflag, which reports as false in a test enviornment. This PR changes it to instead use theenv.command.Fixes #12612
Testing
Docs