Skip to content

Add Astro.fetchContent API#91

Merged
drwpow merged 1 commit into
mainfrom
astro-global
Apr 14, 2021
Merged

Add Astro.fetchContent API#91
drwpow merged 1 commit into
mainfrom
astro-global

Conversation

@drwpow
Copy link
Copy Markdown
Member

@drwpow drwpow commented Apr 13, 2021

Changes

Only renames import.meta.fetchContent() to Astro.fetchContent(). No other changes.

Testing

  • Tests are passing
  • Tests updated where necessary

Docs

  • Docs / READMEs updated
  • Code comments added where helpful

Comment thread test/astro-collection.test.js
@drwpow drwpow force-pushed the astro-global branch 2 times, most recently from 8488c9f to ed2b74c Compare April 13, 2021 22:26
@drwpow drwpow changed the title Add Astro.fetchContent APi Add Astro.fetchContent API Apr 13, 2021
@drwpow
Copy link
Copy Markdown
Member Author

drwpow commented Apr 14, 2021

I’m going to merge this without a review, because this uses the syntax we decided on last week. I want to get this change in as soon as possible before people get used to the wrong one. Happy to tackle any post-merge feedback in a followup PR.

@drwpow drwpow merged commit 3d0d534 into main Apr 14, 2021
@drwpow drwpow deleted the astro-global branch April 14, 2021 00:08
Princesseuh pushed a commit that referenced this pull request Oct 20, 2025
* fix: ignore tsconfig setting files

Astro should not be reading the tsconf settings file.  This causes issues  such as `strict: true` causing ts errors like:

`JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists.`

RE: https://discord.com/channels/830184174198718474/845451724738265138/895704312544653353

Closes #91.

Personal References:
- Link #T-366
- Closes #T-366

* Adding a changeset

* Update the yarn lock

Co-authored-by: Justin Noel <81643826+justinnoel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant