Skip printing createAstro code if unused#1002
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: f02b6de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
approved these changes
Apr 19, 2024
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Very awesome idea, nice work!
ematipico
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Idea from withastro/astro#10773 (review)
If the
Astroglobal is not used, we don't need to print code that callscreateAstro. This saves on runtime execution as it's created but not used.Perf:
createAstro()calls dropped from 571ms o 551ms. -0.02s (not a lot, but it helps other cases instead like garbage collection and AST parsing)garbage collectiondropped from 59.52s to 40.88s. -18.7sTesting
Updated tests to handle cases where the
createAstrocode is no longer present.Docs
n/a. internal improvement.