Skip to content

fix: make tutorial consistent with blog-tutorial-demo (Typescript errors)#10120

Merged
sarah11918 merged 1 commit into
withastro:5.0.0-betafrom
ArmandPhilippot:fix/consistent-tutorial-demo
Nov 30, 2024
Merged

fix: make tutorial consistent with blog-tutorial-demo (Typescript errors)#10120
sarah11918 merged 1 commit into
withastro:5.0.0-betafrom
ArmandPhilippot:fix/consistent-tutorial-demo

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

Description (required)

Fixes two more Typescript errors in the unit 6 of the tutorial. (see withastro/blog-tutorial-demo#33)

Related issues & labels (optional)

  • Suggested label: code snippet update

Fixes two more Typescript errors in ThemeIcon.astro
@astrobot-houston
Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/tutorial/6-islands/2.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 30, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/674b5b2c11373a6a892e5f3a
😎 Deploy Preview https://deploy-preview-10120--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're too good to me, Armand! Going to rerun the Netlify deploy, but I can't thank you enough for your help this weekend at crunch time! 💪

@sarah11918
Copy link
Copy Markdown
Member

Redeploy on Netlify worked!

@sarah11918 sarah11918 merged commit ae619d9 into withastro:5.0.0-beta Nov 30, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/consistent-tutorial-demo branch November 30, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants