fix: make tutorial consistent with blog-tutorial-demo (Typescript errors)#10120
Merged
sarah11918 merged 1 commit intoNov 30, 2024
Merged
Conversation
Fixes two more Typescript errors in ThemeIcon.astro
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
approved these changes
Nov 30, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
You're too good to me, Armand! Going to rerun the Netlify deploy, but I can't thank you enough for your help this weekend at crunch time! 💪
Member
|
Redeploy on Netlify worked! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes two more Typescript errors in the unit 6 of the tutorial. (see withastro/blog-tutorial-demo#33)
Related issues & labels (optional)