Skip to content

fix: remove experimental and update comments in cli-reference.mdx#10193

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/cli-reference
Dec 4, 2024
Merged

fix: remove experimental and update comments in cli-reference.mdx#10193
sarah11918 merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/cli-reference

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

Description (required)

Adds two changes to cli-reference.mdx:

  • the comment above each command was still using "start script" instead of dev so I updated the comments
  • Astro Env was still marked as experimental in the astro sync section so I removed that mention

Related issues & labels (optional)

  • Suggested label: typo/link/grammar - quick fix!

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 4, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be8972a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6750de669734380008b85c60
😎 Deploy Preview https://deploy-preview-10193--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 4, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/cli-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, perfect, and so appreciated! 💜

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 4, 2024
@sarah11918 sarah11918 merged commit a83e736 into withastro:main Dec 4, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/cli-reference branch December 5, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants