Skip to content

fix: remove useless escape character in content-collections.mdx#10213

Merged
yanthomasdev merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/remove-useless-escape-character-loader-again
Dec 5, 2024
Merged

fix: remove useless escape character in content-collections.mdx#10213
yanthomasdev merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/remove-useless-escape-character-loader-again

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

Description (required)

Same as #10209 but with a different pattern:
I haven't noticed this pattern in the previous PR because I was looking for an exact matching... but I checked "**\/*.md" and "**/*.md" are both valid.
So, to avoid confusion whether the editor automatically removes the character or ESlint displays a warning, I removed the useless escape character in some loader patterns in content-collections.mdx.

Related issues & labels (optional)

  • Suggested label: code snippet update

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 5, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/content-collections.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 5, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d55fd61
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/675214a5f074e60008d280f7
😎 Deploy Preview https://deploy-preview-10213--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 5, 2024
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@yanthomasdev yanthomasdev merged commit eede0cf into withastro:main Dec 5, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/remove-useless-escape-character-loader-again branch December 5, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants