Skip to content

Fix call of render function in doc example#10246

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
ancaemcken:patch-1
Dec 6, 2024
Merged

Fix call of render function in doc example#10246
sarah11918 merged 2 commits into
withastro:mainfrom
ancaemcken:patch-1

Conversation

@ancaemcken
Copy link
Copy Markdown
Contributor

@ancaemcken ancaemcken commented Dec 6, 2024

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 6, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bb0f6c9
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/675346bcdd78f000089f2743
😎 Deploy Preview https://deploy-preview-10246--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 6, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/markdown-content.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 6, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

sarah11918
sarah11918 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to improve the docs! I just corrected the code sample (content collections are a little different now in v5, and your proposal would have been correct for v4), but they were absolutely missing product.

Welcome to Team Docs! 🥳

Comment thread src/content/docs/en/guides/markdown-content.mdx Outdated
@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 6, 2024
@sarah11918 sarah11918 merged commit a779873 into withastro:main Dec 6, 2024
@jsparkdev jsparkdev mentioned this pull request Dec 7, 2024
Closed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 9, 2024
@ArmandPhilippot
i18n(fr): update guides/markdown-content.mdx
c5d5172 
See withastro#9240 and withastro#10246
@ArmandPhilippot ArmandPhilippot mentioned this pull request Dec 9, 2024
Merged
thomasbnt added a commit that referenced this pull request Dec 11, 2024
@ArmandPhilippot @thomasbnt
i18n(fr): update guides/markdown-content.mdx (#10319)
92de0b8 
* i18n(fr): update `guides/markdown-content.mdx`

See #9240 and #10246

* revert ReadMore, it will come back soon

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
@liruifengv liruifengv mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ancaemcken @astrobot-houston @sarah11918