Skip to content

feat(link): update link in guides/deploy/aws because it now links to same page [i18nIgnore]#10255

Merged
yanthomasdev merged 2 commits into
withastro:mainfrom
trueberryless:shorten-link-in-aws
Dec 7, 2024
Merged

feat(link): update link in guides/deploy/aws because it now links to same page [i18nIgnore]#10255
yanthomasdev merged 2 commits into
withastro:mainfrom
trueberryless:shorten-link-in-aws

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

Description (required)

The link /en/guides/deploy/aws/#s3-static-website-hosting can be shortened to just #s3-static-website-hosting because the heading is on the same page.

Related issues & labels (optional)

  • Suggested label: link?

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 6, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c76f3da
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6754702c0f558b00080ea65f
😎 Deploy Preview https://deploy-preview-10255--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 6, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/aws.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@yanthomasdev yanthomasdev added the typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. label Dec 7, 2024
@yanthomasdev yanthomasdev changed the title feat(link): update link in guides/deploy/aws because it now links to same page feat(link): update link in guides/deploy/aws because it now links to same page [i18nIgnore] Dec 7, 2024
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit a4b2e3f into withastro:main Dec 7, 2024
@trueberryless trueberryless deleted the shorten-link-in-aws branch December 7, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants