Skip to content

[i18nIgnore] update command for creating a new project with react and tailwind#10303

Merged
yanthomasdev merged 1 commit into
withastro:mainfrom
otacleT:otaclet/fix-setup-command-with-multiple-integrations
Dec 8, 2024
Merged

[i18nIgnore] update command for creating a new project with react and tailwind#10303
yanthomasdev merged 1 commit into
withastro:mainfrom
otacleT:otaclet/fix-setup-command-with-multiple-integrations

Conversation

@otacleT
Copy link
Copy Markdown
Contributor

@otacleT otacleT commented Dec 8, 2024

Description (required)

Modify the commands in the Add integrations section to correctly create a new project with React and Tailwind.
Adjusted the syntax to ensure proper handling of multiple integrations with the --add flag.

FYI: https://docs.astro.build/en/install-and-setup/#add-integrations

Related issues & labels (optional)

Discord username: Taisei

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 8, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 8, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9f271b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6755a7c849c857000872047a
😎 Deploy Preview https://deploy-preview-10303--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

File Note
en/install-and-setup.mdx Source changed, localizations will be marked as outdated.
ko/install-and-setup.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @otacleT and welcome to team Docs! 🎉 Nice catch, thanks!

I can confirm that the previous command was not working while your fix works! So, LGTM!

Just a note for future contribution: Usually we only fix the English version and we let our translators apply the changes to their language. But you rightfully use the i18nIgnore so I guess it's fine here! Thanks again!

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM! 💜

@yanthomasdev yanthomasdev merged commit 325b758 into withastro:main Dec 8, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 12, 2024
thomasbnt added a commit that referenced this pull request Dec 12, 2024
* i18n(fr): update `install-and-setup.mdx`

See #9240, #10144 and #10303

* fix missing link update

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Command to Create a New Astro Project with Multiple Integrations

4 participants