Skip to content

fix: remove unnecessary await before import.meta.glob#10310

Merged
TheOtterlord merged 2 commits into
withastro:mainfrom
kidonng:patch-1
Dec 9, 2024
Merged

fix: remove unnecessary await before import.meta.glob#10310
TheOtterlord merged 2 commits into
withastro:mainfrom
kidonng:patch-1

Conversation

@kidonng
Copy link
Copy Markdown
Contributor

@kidonng kidonng commented Dec 9, 2024

Description (required)

When used with { eager: true }, import.meta.glob no longer returns a promise and thus no longer needs await.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e88b843
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67570288e4a0750008e9dea4
😎 Deploy Preview https://deploy-preview-10310--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 9, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/imports.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 9, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

TheOtterlord
TheOtterlord approved these changes Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@TheOtterlord TheOtterlord merged commit 5920932 into withastro:main Dec 9, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 9, 2024
@ArmandPhilippot
i18n(fr): update guides/imports.mdx
22dd326 
See withastro#9240, withastro#10140, withastro#10310 and withastro#10315
@ArmandPhilippot ArmandPhilippot mentioned this pull request Dec 9, 2024
Closed
@jsparkdev jsparkdev mentioned this pull request Dec 9, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 10, 2024
@ArmandPhilippot
i18n(fr): update guides/imports.mdx
84064ed 
See withastro#9240, withastro#10140, withastro#10310 and withastro#10315
@ArmandPhilippot ArmandPhilippot mentioned this pull request Dec 10, 2024
Merged
thomasbnt added a commit that referenced this pull request Dec 11, 2024
@ArmandPhilippot @thomasbnt
i18n(fr): update guides/imports.mdx & migrate-to guides (#10331)
ee69ae7 
* i18n(fr): update all the `migrate-to` guides

Signed-off-by: Armand Philippot <git@armand.philippot.eu>

* i18n(fr): update `guides/imports.mdx`

See #9240, #10140, #10310 and #10315

* farewell `Astro.glob`

* fix wrong locale

* fix bold text

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* remove useless await

see #10332

---------

Signed-off-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
@trueberryless trueberryless mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheOtterlord TheOtterlord TheOtterlord approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kidonng @astrobot-houston @TheOtterlord