Skip to content

i18n(fr) Up and Add french translation for upgrade-astro.mdx and v5.mdx#10314

Merged
thomasbnt merged 49 commits into
withastro:mainfrom
McFlyPartages:up_fr_upgrade-astro
Dec 11, 2024
Merged

i18n(fr) Up and Add french translation for upgrade-astro.mdx and v5.mdx#10314
thomasbnt merged 49 commits into
withastro:mainfrom
McFlyPartages:up_fr_upgrade-astro

Conversation

@McFlyPartages
Copy link
Copy Markdown
Contributor

Description (required)

Tranlation for french doc

Update upgrade-astro file and add v5 astro file

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 9, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 9, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a6b07f5
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/675a0cf769dc120008eeac83
😎 Deploy Preview https://deploy-preview-10314--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 9, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/guides/upgrade-to/v5.mdx Localization added, will be marked as complete.
fr/reference/errors/content-collection-type-mismatch-error.mdx Localization changed, will be marked as complete.
fr/reference/errors/content-schema-contains-slug-error.mdx Localization changed, will be marked as complete.
fr/reference/errors/mixed-content-data-collection-error.mdx Localization changed, will be marked as complete.
fr/reference/integrations-reference.mdx Localization changed, will be marked as complete.
fr/upgrade-astro.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ! Thanks for the PR, a few adjustments in MD and it looks good!

Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this big file! I suggested some changes:

  • mostly nitpicks (missing space, double dot...)
  • some untranslated strings
  • some malformed inline codes
  • some malformed links

Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
McFlyPartages and others added 17 commits December 10, 2024 17:26
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
McFlyPartages and others added 10 commits December 10, 2024 17:40
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the broken links!

Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/reference/integrations-reference.mdx Outdated
McFlyPartages and others added 2 commits December 11, 2024 08:15
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@McFlyPartages
Copy link
Copy Markdown
Contributor Author

Hey thanks for your review. It's good now

Thanks Thanks Thanks and good job

Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny nits, otherwise LGTM!

Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
thomasbnt and others added 2 commits December 11, 2024 22:54
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss one link #importmetaglob and LGTM!

Comment thread src/content/docs/fr/guides/upgrade-to/v5.mdx Outdated
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants