Skip to content

fix: malformed code snippet in integrations-guide/mdx.mdx#10344

Merged
yanthomasdev merged 3 commits into
withastro:mainfrom
ArmandPhilippot:fix/integrations-guide/mdx
Dec 11, 2024
Merged

fix: malformed code snippet in integrations-guide/mdx.mdx#10344
yanthomasdev merged 3 commits into
withastro:mainfrom
ArmandPhilippot:fix/integrations-guide/mdx

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot commented Dec 11, 2024

Description (required)

  • The code snippet in the Using MDX with content collections section had an unclosed function, so I fixed it
  • There was a typo in the section heading wth > with

I don't know if other languages ​​than Korean are already up to date on this file, so I didn't included the changes on the Korean version.

Related issues & labels (optional)

  • Suggested label: typo, code snippet update

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 11, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e584a37
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/675a1644393cd90008701764
😎 Deploy Preview https://deploy-preview-10344--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 11, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/mdx.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanthomasdev yanthomasdev added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. code snippet update Updates a code sample: typo, outdated code etc. labels Dec 11, 2024
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit bbf567e into withastro:main Dec 11, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/integrations-guide/mdx branch December 11, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants