Skip to content

i18n(zh-cn): Add on-demand-rendering.mdx#10736

Merged
liruifengv merged 15 commits into
withastro:mainfrom
MonchiLin:main
Jan 23, 2025
Merged

i18n(zh-cn): Add on-demand-rendering.mdx#10736
liruifengv merged 15 commits into
withastro:mainfrom
MonchiLin:main

Conversation

@MonchiLin
Copy link
Copy Markdown
Contributor

@MonchiLin MonchiLin commented Jan 21, 2025

Add src/content/docs/zh-cn/guides/on-demand-rendering.mdx

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 21, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 21651b2
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6791a6a6af698f0008097116
😎 Deploy Preview https://deploy-preview-10736--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jan 21, 2025

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jan 21, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
zh-cn/guides/astro-db.mdx Localization changed, will be marked as complete.
zh-cn/guides/on-demand-rendering.mdx Localization added, will be marked as complete.
zh-cn/reference/integrations-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Nin3lee
Nin3lee suggested changes Jan 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nin3lee Nin3lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哈喽 MonchiLin！欢迎你加入简中文档翻译的团队，感谢你对这篇 on-demand-rendering.mdx 文档翻译投入的时间和精力。

我在建议中标注了几处需要修改的部分，多数是关于链接锚点的，可以在查看后应用修改。另外我还注意到和源文档不同的一处标点（位于第 99 行的：），以及一处主动添加代码注释的文本（位于第 248 行的 body），因为我觉得利于阅读所以我选择保留了。

Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
@MonchiLin
Copy link
Copy Markdown
Contributor Author

MonchiLin commented Jan 21, 2025

@Nin3lee 非常感谢你的审核和指正, 之前确实不了解锚点的转换规则

Nin3lee
Nin3lee approved these changes Jan 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nin3lee Nin3lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💜 Thanks again for your effort and time to contribute.

Maybe other maintainers will have their own suggestions.

@Nin3lee Nin3lee mentioned this pull request Jan 21, 2025
Merged
@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Jan 21, 2025

感谢你的翻译。被 review 的修改建议，需要点击 commit suggestion 才行，或者在本地修改完提交。修改完成之后再点击 resolve。 @MonchiLin

liruifengv
liruifengv reviewed Jan 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里还有一点修改。还有上面 @Nin3lee Review 的

Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
Comment thread src/content/docs/zh-cn/guides/on-demand-rendering.mdx Outdated
MonchiLin and others added 10 commits January 21, 2025 17:18
@MonchiLin @Nin3lee
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
092e1c4 
Co-authored-by: Nin3 <30520689+Nin3lee@users.noreply.github.com>
@MonchiLin @Nin3lee
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
3039d21 
Co-authored-by: Nin3 <30520689+Nin3lee@users.noreply.github.com>
@MonchiLin @Nin3lee
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
25e63b0 
Co-authored-by: Nin3 <30520689+Nin3lee@users.noreply.github.com>
@MonchiLin @Nin3lee
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
503f11f 
Co-authored-by: Nin3 <30520689+Nin3lee@users.noreply.github.com>
@MonchiLin @Nin3lee
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
85058f1 
Co-authored-by: Nin3 <30520689+Nin3lee@users.noreply.github.com>
@MonchiLin @liruifengv
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
099b2f9 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
@MonchiLin @liruifengv
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
e669e61 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
@MonchiLin @liruifengv
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
0ccf8f0 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
@MonchiLin @liruifengv
Update src/content/docs/zh-cn/guides/on-demand-rendering.mdx
07ff01a 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
@MonchiLin
Merge branch 'main' into main
8f01b69
@MonchiLin
Copy link
Copy Markdown
Contributor Author

MonchiLin commented Jan 21, 2025

这里还有一点修改。还有上面 @Nin3lee Review 的

:) 感谢, 已修改

@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Jan 22, 2025

image

@MonchiLin 这里有三处 broken links，因为其他页面引用了这个页面的链接，需要同步更新一下

@MonchiLin
Copy link
Copy Markdown
Contributor Author

MonchiLin commented Jan 22, 2025

image

@MonchiLin 这里有三处 broken links，因为其他页面引用了这个页面的链接，需要同步更新一下

:) 已同步修改

liruifengv
liruifengv reviewed Jan 22, 2025
View reviewed changes
Comment thread src/content/docs/zh-cn/guides/astro-db.mdx Outdated
liruifengv
liruifengv reviewed Jan 22, 2025
View reviewed changes
Comment thread src/content/docs/zh-cn/reference/integrations-reference.mdx Outdated
liruifengv
liruifengv reviewed Jan 22, 2025
View reviewed changes
Comment thread src/content/docs/zh-cn/reference/integrations-reference.mdx Outdated
@MonchiLin
Copy link
Copy Markdown
Contributor Author

MonchiLin commented Jan 22, 2025

@liruifengv 已修复, 感谢你的耐心 :)

liruifengv
liruifengv approved these changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! @MonchiLin and Thanks @Nin3lee for review. Welcome to Team Docs!

@liruifengv liruifengv merged commit 19c4552 into withastro:main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liruifengv liruifengv liruifengv approved these changes

+1 more reviewer

@Nin3lee Nin3lee Nin3lee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MonchiLin @astrobot-houston @liruifengv @Nin3lee