Skip to content

fix: update astro-pages.mdx#11137

Merged
yanthomasdev merged 7 commits into
withastro:mainfrom
jsparkdev:0304-ko
Mar 4, 2025
Merged

fix: update astro-pages.mdx#11137
yanthomasdev merged 7 commits into
withastro:mainfrom
jsparkdev:0304-ko

Conversation

@jsparkdev
Copy link
Copy Markdown
Member

@jsparkdev jsparkdev commented Mar 4, 2025

Description (required)

  • update astro-pages.mdx
  • add and remove spaces
  • update code blocks
  • add links

@jsparkdev jsparkdev marked this pull request as draft March 4, 2025 05:06
@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 4, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 4, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 07c10d5
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67c6e5fa500dfa0008c6f63d
😎 Deploy Preview https://deploy-preview-11137--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Mar 4, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/basics/astro-pages.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@jsparkdev jsparkdev added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Mar 4, 2025
@jsparkdev jsparkdev marked this pull request as ready for review March 4, 2025 05:29
@liruifengv
Copy link
Copy Markdown
Member

Hi @jsparkdev. I think we need to separate the English and Korean updates. Would you like to split him into two PRs?

@github-actions github-actions Bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 4, 2025
@jsparkdev
Copy link
Copy Markdown
Member Author

@liruifengv

Thank you!

I only left the English documentation changes.

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit 8a9c32f into withastro:main Mar 4, 2025
@jsparkdev jsparkdev deleted the 0304-ko branch March 4, 2025 11:45
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Mar 4, 2025
ArmandPhilippot added a commit that referenced this pull request Mar 4, 2025
See #11137

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants