Skip to content

Update the Deno guide and logo#11197

Merged
ArmandPhilippot merged 7 commits into
withastro:mainfrom
lucacasonato:update_deno_docs
Mar 11, 2025
Merged

Update the Deno guide and logo#11197
ArmandPhilippot merged 7 commits into
withastro:mainfrom
lucacasonato:update_deno_docs

Conversation

@lucacasonato
Copy link
Copy Markdown
Contributor

@lucacasonato lucacasonato commented Mar 11, 2025 •
edited
Loading

Description (required)

This commit updates the Deno guide to be more up to date, and to include an example for how to run your Astro app with Deno, outside of Deno Deploy.

Related issues & labels (optional)

@lucacasonato
Update the Deno guide and logo
12cd170 
This commit updates the Deno guide to be more up to date, and to include an example for how to run your Astro app with Deno, outside of Deno Deploy.
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 11, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b5a2e35
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67d07b87d4aeb5000866255d
😎 Deploy Preview https://deploy-preview-11197--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Mar 11, 2025

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Mar 11, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/deno.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 reviewed Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucacasonato for providing these super helpful updates! 🙌

I will let @ArmandPhilippot give the final review since he is familiar with the issue, but I just took a quick scan and made a few text updates in keeping with Astro Docs style.

Comment thread src/content/docs/en/guides/deploy/deno.mdx Outdated
Comment thread src/content/docs/en/guides/deploy/deno.mdx Outdated
ArmandPhilippot
ArmandPhilippot reviewed Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of the update! I left two suggestions:

  • to compress the logo with SVGOMG
  • to use the PackageManagerTabs component instead of regular code blocks for the npm commands. This is not required (we can always do that later!) but that would be a great addition if you feel comfortable updating all npm code blocks in the page.

Comment thread public/logos/deno.svg Outdated
Comment thread src/content/docs/en/guides/deploy/deno.mdx Outdated
lucacasonato
lucacasonato commented Mar 11, 2025
View reviewed changes
Comment thread src/content/docs/en/guides/deploy/deno.mdx

3. Run `deployctl` to deploy!

In the command below, replace `<ACCESS-TOKEN>` with your [Personal Access Token](https://dash.deno.com/account#access-tokens) and `<MY-DENO-PROJECT>` with your Deno Deploy project name.
Copy link
Copy Markdown
Contributor Author

@lucacasonato lucacasonato Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployctl does interactive auth as part of invocation now - no need to specify the token upfront.

lucacasonato and others added 2 commits March 11, 2025 15:43
@lucacasonato @ArmandPhilippot
SVGOMG
28ebb7f 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@yanthomasdev
Merge branch 'main' into update_deno_docs
7876d74
@ArmandPhilippot ArmandPhilippot added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Mar 11, 2025
ArmandPhilippot
ArmandPhilippot approved these changes Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for taking the time to update the guide, and welcome to Team Docs! 🎉

Comment thread src/content/docs/en/guides/deploy/deno.mdx Outdated
@ArmandPhilippot ArmandPhilippot merged commit e3fde05 into withastro:main Mar 11, 2025
@jsparkdev jsparkdev mentioned this pull request Mar 12, 2025
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Mar 12, 2025
@ArmandPhilippot
i18n(fr): update guides/deploy/deno.mdx
999b6f1 
See withastro#11197
@ArmandPhilippot ArmandPhilippot mentioned this pull request Mar 12, 2025
Merged
thomasbnt added a commit that referenced this pull request Mar 12, 2025
@ArmandPhilippot @thomasbnt
i18n(fr): update guides/deploy/deno.mdx (#11209)
42cba87 
See #11197

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
@maxchang3 maxchang3 mentioned this pull request Mar 16, 2025
Merged
@deining deining mentioned this pull request Apr 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

Assignees

No one assigned

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deno page has incorrect astro add command

5 participants

@lucacasonato @astrobot-houston @sarah11918 @ArmandPhilippot @yanthomasdev