Core Concepts PR follow-up#1126
Merged
Merged
Conversation
Original stat referenced reads: “every additional second a page takes to load, 10 per cent of users leave.”
Sidebar was illegible in dark mode
Opening suggested “Astro Islands” coined by Katie Sylor-Miller when component islands or islands architecture make more sense.
Co-Authored-By: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
Bot
added
the
i18n
yanthomasdev
approved these changes
Jul 27, 2022
Member
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this @delucis 🙌
sarah11918
reviewed
Jul 27, 2022
Member
|
One little text comment @delucis , but otherwise, LGTM! Thanks for tackling this! |
matthewp
approved these changes
Jul 27, 2022
tony-sull
approved these changes
Jul 27, 2022
Who needs em! Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
I hadn’t realised #893 was so close to being merged, so failed to prioritise getting a review in — sorry about that! This PR is a follow-up, mainly taking care of infrastructural details and some i18n stuff that was overlooked. I also spotted a few typos. Obviously, not being a review, I’ve had to just jump in and do stuff, hope that’s OK — I’m happy to revert anything that doesn’t make sense.
partial-hydrationpages into ourold-translationsarchive directory for reference when translators come to translate the new islands page. I also made redirects for that page work across languages.While I was there I also took the liberty to: