[i18nIgnore] update CMS nav component logic#12842
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
This was a lot of changes! But everything looks good to me, well done! 🙌🏽
I don't think we actually use logic depending on slug anymore for any of these guides? If not, then a followup PR could remove the slug property from every guide, of every kind.
You mean stub not slug, right? If so, I don't have the history so I'm not sure when/how this was used. But, yeah, I think this is no longer used and this is safe to remove!

This PR updates our CMS nav component to match the logic of the recently updated deploy guide nav component.
It is an analogous update to the backend nav component done in #12759
Notably:
logoproperty for grabbing the logo and thesidebar.labelproperty for generating the name under the iconlogoservicewithlogo, ensuring the value matches the value inlogos.tsand checking thatsidebar.labelexists.While I was there, I alphabetized
logos.tsto make things easier going forward.Note: no filenames changed, so no redirects needed
Future Consideration:
stubanymore for any of these guides? If not, then a followup PR could remove thestubproperty from every guide, of every kind.