[i18nIgnore] Update media guide nav component logic#12844
Merged
Conversation
github-actions
Bot
added
the
i18n
Contributor
Lunaria Status Overview🌑 This pull request will not trigger status changes. Learn moreLunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: You can change this by either removing the keyword above from the PR's title, or modifying the Tracked FilesNote The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArmandPhilippot
approved these changes
Dec 5, 2025
Member
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
A nit, but otherwise this looks like a well handled PR to conclude the week! 🎉
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates our media nav component to match the logic of the recently updated deploy guide nav component.
It is an analogous update to the backend nav component done in #12759
Notably:
logoproperty for grabbing the logo and thesidebar.labelproperty for generating the name under the iconlogoservicewithlogo, ensuring the value matches the value inlogos.tsand checking thatsidebar.labelexists.While I was updating the schema, I grouped all the third-party service schemas that work this way together.
Note: Other nav components (e.g. integrations, migration guides) rely on the logos too, but their pages and schema are different enough (and, these pages aren't added by community members) that I don't think we need to worry about updating any more of these nav components.
Future work:
This PR completes updating all our third-party guide logic, so I can now update the contributing guide with definitive instructions for adding a new Astro + X guide.