Expand the fonts guide with variable fonts, preloading & fontData #13650
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
florian-lefebvre
left a comment
There was a problem hiding this comment.
Looks awesome! Just one comment
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
yanthomasdev
left a comment
There was a problem hiding this comment.
Amazing work here, two small suggestions from me so far.
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
|
Because the suggestions couldn't be applied (I don't know what happened with dbb79ed... The entire file was considered modified), I just pushed three new commits with what we discussed: |
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
|
I'll wait for @yanthomasdev in case he wants to double check the new changes! And because I just saw 5b5e788 has the same issue as the previous commit (everything seems updated...), here is what I've done in this commit in addition to rename/reorder the tabs: I shortened the first sentence in "Using variable fonts" and reworded a bit the first sentence in "Other providers". |
|
I marked 13583 as closed by this PR. This PR addresses all the docs part, the rest is code related and I'm tracking it somewhere else |
yanthomasdev
left a comment
There was a problem hiding this comment.
Great work, just one final nit and it's good to be shipped 🫡
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
|
Great, two more issues closed! 🎉 Thank you both for the reviews! |
Description (required)
We had several reports here (#13635, #13583, #13324) and on Discord about the fonts guide:
<Font />reference) and some people wants to preload their fontsRegarding the last point, I know Florian plans to improve the API but in the meantime, I think it's a good idea to improve the documentation, because this specific use case is of interest to many people.
This PR:
FontDatatype description, I think this can be helpful for people using font data programmatically.cc @florian-lefebvre (no rush, this is in draft on purpose!), feel free to comment on the changes and/or push to my branch directly if your prefer!
I know you didn't want to highlight
preloadbut since this option is available, I think it makes sense to mention it in the guide, with the same caution.Related issues & labels (optional)