Fix out-of-memory Netlify deploys for external contributors#2252
Merged
Conversation
To solve out-of-memory issues when building docs we set a `NODE_OPTIONS` environment variable in Netlify’s dashboard to increase the default memory limit. This worked fine in internal tests because those of us trying it out are included in the Netlify team. Now that external contributors are triggering deploys, Netlify is not using the environment variable for those builds because it considers all environment variables as “sensitive” (which some are, like our GitHub API key). Without `NODE_OPTIONS` the build fails. This fix moves where we set the variable directly into the build command specified in `netlify.toml`. I would expect Netlify to then use `NODE_OPTIONS` correctly for all PRs.
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
To solve out-of-memory issues when building docs we set a
NODE_OPTIONSenvironment variable in Netlify’s dashboard to increase the default memory limit. This worked fine in internal tests because those of us trying it out are included in the Netlify team. Now that external contributors are triggering deploys, Netlify is not using the environment variable for those builds because it considers all environment variables as “sensitive” (which some are, like our GitHub API key). WithoutNODE_OPTIONSthe build fails (see #2251 for example).This fix moves where we set the variable directly into the build command specified in
netlify.toml. I would expect Netlify to then useNODE_OPTIONScorrectly for all PRs.