Skip to content

Update Google Cloud docs with Docker recipe#2935

Merged
sarah11918 merged 4 commits into
withastro:mainfrom
ElianCodes:improve-docker-docs
Mar 29, 2023
Merged

Update Google Cloud docs with Docker recipe#2935
sarah11918 merged 4 commits into
withastro:mainfrom
ElianCodes:improve-docker-docs

Conversation

@ElianCodes
Copy link
Copy Markdown
Member

What kind of changes does this PR include?

  • New or updated content

Description

Updates the Google Cloud documentation to refer to the Docker Recipe instead of having double content.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 27, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 08b9a60
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6424b4cbe937660008ce5a1f
😎 Deploy Preview https://deploy-preview-2935--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ElianCodes
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @ElianCodes, thanks for this! I added a small suggestion, after addressing it LGTM 🙌

Comment thread src/content/docs/en/guides/deploy/google-cloud.mdx Outdated
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@ElianCodes
Copy link
Copy Markdown
Member Author

@yan-thomas I also fixed my previous mistakes in PR #2936

Comment thread src/content/docs/en/guides/deploy/google-cloud.mdx Outdated
@sarah11918 sarah11918 merged commit 6bae4c9 into withastro:main Mar 29, 2023
@ElianCodes ElianCodes deleted the improve-docker-docs branch April 2, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we remove the Docker examples from GCP deploy guide?

3 participants