Skip to content

RSS Recipe Next Steps#3285

Merged
sarah11918 merged 18 commits into
withastro:mainfrom
Jothsa:rssRecipe
May 24, 2023
Merged

RSS Recipe Next Steps#3285
sarah11918 merged 18 commits into
withastro:mainfrom
Jothsa:rssRecipe

Conversation

@Jothsa
Copy link
Copy Markdown
Contributor

@Jothsa Jothsa commented May 18, 2023

What kind of changes does this PR include?

  • New or updated content

Description

Thanks to @sarah11918 for the text I used.

I believe the address to visit to check your rss feed is my-site.com/rss.xml. I'm not 100% sure of the best/least awkward way to phrase that.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ae598b9
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/646df735a245200008918636
😎 Deploy Preview https://deploy-preview-3285--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jothsa
Copy link
Copy Markdown
Contributor Author

Jothsa commented May 19, 2023

I'll edit this a bit now that I've read WRITING.md and RECIPES.md 😅

@sarah11918
Copy link
Copy Markdown
Member

This is my favourite PR comment EVER, @Jothsa 🤣

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Jothsa, there are some great improvements here! I've left some suggestions since this is a good excuse for me to review this page more generally, too!

Comment thread src/content/docs/en/guides/rss.mdx Outdated
Comment thread src/content/docs/en/guides/rss.mdx Outdated
Comment thread src/content/docs/en/guides/rss.mdx Outdated
Comment thread src/content/docs/en/guides/rss.mdx Outdated
Comment thread src/content/docs/en/guides/rss.mdx
Comment thread src/content/docs/en/guides/rss.mdx Outdated
Comment thread src/content/docs/en/guides/rss.mdx
Comment thread src/content/docs/en/guides/rss.mdx Outdated
@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label May 22, 2023
Jothsa and others added 6 commits May 22, 2023 11:29
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@Jothsa
Copy link
Copy Markdown
Contributor Author

Jothsa commented May 22, 2023

Thanks so much, @sarah11918!

@Jothsa
Copy link
Copy Markdown
Contributor Author

Jothsa commented May 22, 2023

Not sure why the checks keep failing. Looks like fontsource is down.

If a sentence ends with a link, should the punctuation be included in the link or not? I try to include it

@sarah11918
Copy link
Copy Markdown
Member

Yup, we haven't been merging all afternoon because fontsource is down! Chris is working on a hotfix, and worst case, we wait until tomorrow.

If the sentence ends with link, the period is NOT included with the link! Punctuation is always separate from the text. :)

Comment thread src/content/docs/en/guides/rss.mdx Outdated
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a small typo, overall LGTM!

Comment thread src/content/docs/en/guides/rss.mdx Outdated
sarah11918 and others added 2 commits May 24, 2023 08:38
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@sarah11918 sarah11918 merged commit 4af6dfc into withastro:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RSS recipe missing final implementation step

3 participants