Update content-collections.mdx: true drafts#3416
Merged
Merged
Conversation
Looks like this is what it was previous to withastro#2371. Filtering to non-drafts makes sense too, but currently either the variable name (and the copy above) or the filter should change for consistency.
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
reviewed
Jun 4, 2023
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Hey @colmanhumphrey, thanks for spotting this!
You're right that it's inconsistent now, and I think it's probably more helpful to filter OUT draft posts, since that's what people are more likely to be doing. So, I think Fred's code had the write idea, but probably slipped up when updating the text.
Left some suggestions that I think would work, for your consideration!
sarah11918
reviewed
Jun 4, 2023
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Member
|
This is wonderful, thanks so much for this fix! Will merge as soon as the checks pass, and welcome to Team Docs! 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description