Skip to content

Add warning about named slot usage#3516

Merged
ElianCodes merged 2 commits into
withastro:mainfrom
TheOtterlord:slots
Jun 26, 2023
Merged

Add warning about named slot usage#3516
ElianCodes merged 2 commits into
withastro:mainfrom
TheOtterlord:slots

Conversation

@TheOtterlord
Copy link
Copy Markdown
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

  • What does this PR change? Adds a warning to specify that usage of named slots has to be top-level.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 16, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d4153b8
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/649080740fb1d900070cd15b
😎 Deploy Preview https://deploy-preview-3516--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheOtterlord, great job 🙌!

Comment thread src/content/docs/en/core-concepts/astro-components.mdx Outdated
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 🚀

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jun 20, 2023
@ElianCodes
Copy link
Copy Markdown
Member

ElianCodes commented Jun 26, 2023

Since this has a few of LGTM's, I'm gonna merge this one!

@ElianCodes ElianCodes merged commit 6cbb552 into withastro:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants